Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Usage report #13

Merged
merged 21 commits into from
Aug 23, 2024
Merged

AWS Usage report #13

merged 21 commits into from
Aug 23, 2024

Conversation

ateucher
Copy link
Member

@ateucher ateucher commented Jul 4, 2024

Hi @jules32, I think this is in a good place for an initial review. You probably won't be able to run it as-is, as there are some credentials you need to set up (and I haven't written up the instructions for that yet).

I also haven't set up the automation with GitHub actions, but have run it several times by setting the year_month parameter and that is working well.

I haven't written too much contextual explanataion for the figures yet, but wanted to get your opinion at this point, then I can flesh it out.

I've attached three samples in the comment below - if you can have a look at those and let me know what you think is missing, I can tweak!

@ateucher
Copy link
Member Author

ateucher commented Jul 4, 2024

I've attached three versions of the report here - for April, May, and June:

aws-usage-report_2024-04.pdf
aws-usage-report_2024-05.pdf
aws-usage-report_2024-06.pdf

@ateucher ateucher requested a review from jules32 July 4, 2024 22:40
@jules32
Copy link
Contributor

jules32 commented Jul 8, 2024

Thanks @ateucher , this is great progress! I made a few starter comments but please continue with the contextual explanation; this is definitely on the right track!

On the next round of reviews I can think more about how to help draw out the current month details (since page 1 is currently constant on each month report).

Copy link
Contributor

@jules32 jules32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andy! Here is the starter review. Great work!

aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Show resolved Hide resolved
@ateucher
Copy link
Member Author

ateucher commented Jul 8, 2024

Thanks @jules32, great suggestions! Re the first page being constant - I think it is different for each report? My intention with the first three figures was to have the reporting month compared to the previous 5 months, and then for the rest of it dive more deeply into the current month being reported on.

@jules32
Copy link
Contributor

jules32 commented Jul 8, 2024

Sounds good Andy - I was thinking about the Introduction Page being largely constant at this point. We can think about that more as you write the contextual text and maybe we end up shifting some intro text?

Copy link
Member Author

@ateucher ateucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules32 I've made most of the changes you suggested and added a bit of a narrative to the figures. I've tried to be general enough that it will make sense regardless of what the figures show :)

Edit: New versions of pdfs attached:

aws-usage-report_2024-04.pdf
aws-usage-report_2024-05.pdf
aws-usage-report_2024-06.pdf

@jules32
Copy link
Contributor

jules32 commented Jul 10, 2024

Thanks @ateucher ! This looks good and I'll have a deeper look with feedback while you're away.

One question: in the "Total size of user home directories by access team and Hub namespace" figure, what does the Yellow N/A mean? (and thinking we should number figures, I'll include that in my review).

@ateucher
Copy link
Member Author

Thanks for looking again @jules32! The N/A means that there is no team associated with the workshop Hub space, since we use the shared password approach for that Hub.

aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Outdated Show resolved Hide resolved
aws-usage-report/aws-usage-report.qmd Show resolved Hide resolved
@jules32
Copy link
Contributor

jules32 commented Jul 15, 2024

Hi Andy! I just reviewed, making some small suggestions and also this bigger question about how to include this idea of human annotation.

I also just shared during our 2i2cAccessPolicy Hackday, and Yuvi, Eli, and Luis are excited. People asked whether this be more real-time (daily? or weekly, could we email users? and what info would change? still a PDF?) People are definitely interested in how this could be useful for other Hubs too. Jim asked how this could be used to communicate to funders as well as users, which is a good question. Communication as the #1 goal here.

Anyways, a lot of interest. I think getting the automation setup for these PDFs monthly first is still best, and then we can fine-tune and add features from there.

Awesome work!

@ateucher
Copy link
Member Author

Related: 2i2c-org/infrastructure#4453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants