Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab/fix no2 rescale #118

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Ab/fix no2 rescale #118

merged 1 commit into from
Feb 16, 2024

Conversation

abarciauskas-bgse
Copy link
Contributor

At some point the no2-monthly collection lost the cog_default data from "summaries". This fixes that issue but it may be something that needs to be addressed in the collection itself as well.

I found an example of a collection that does have the cog_default object in it's summaries object: https://staging-stac.delta-backend.com/collections/ecco-surface-height-change.

https://staging-stac.delta-backend.com/collections/no2-monthly has no cog_default object in it's summaries.

cc @anayeaye

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Feb 15, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-118/
on branch gh-pages at 2024-02-15 15:20 UTC

@anayeaye
Copy link
Collaborator

anayeaye commented Feb 16, 2024

@abarciauskas-bgse thanks for catching this! When we moved to multi-assets for collections we removed the automated generation of cog_default min max in summaries because this asset is no longer guaranteed in all collections. When the render metadata are published for this no2-monthly collection, I think we should revisit this notebook to utilize them in the absence of a cog_default summary.

EDIT: also when we update that collection, we'll be fixing the other issues that make the collection invalid. Hopefully that is very soon.

@abarciauskas-bgse abarciauskas-bgse merged commit 5474d20 into main Feb 16, 2024
1 check passed
@abarciauskas-bgse
Copy link
Contributor Author

@anayeaye thanks for reviewing - it might be overkill but I wonder if integration tests from NASA-IMPACT/veda-jh-environments#44 could be run whenever there are large STAC metadata changes 🤔

@wildintellect wildintellect deleted the ab/fix-no2-rescale branch August 15, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants