Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apis.qmd #105

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Update apis.qmd #105

merged 3 commits into from
Oct 18, 2023

Conversation

abarciauskas-bgse
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse commented Sep 28, 2023

Fix links to dev APIs

We also need to update the dev stac browser to use https://dev-stac.delta-backend.com/api/stac/ but I'm not sure where that deployment is being maintained at the moment. @anayeaye @slesaad if you point me in the right direction I can try and update the dev STAC browser.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-105/
on branch gh-pages at 2023-10-16 14:45 UTC

@anayeaye
Copy link
Collaborator

@abarciauskas-bgse the current veda-dev stack browser bucket (veda-dev-stac-browser) is in the veda-uah/covid-response account and was manually deployed. Automating that process is in active development (https://github.com/NASA-IMPACT/veda-architecture/issues/305, NASA-IMPACT/veda-backend#222).
cc: @smohiudd @emileten

Copy link
Collaborator

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs are repeated in a bunch of the notebooks. The intention is to have them not change again right?

@smohiudd
Copy link
Collaborator

The URLs should be pretty stable now for dev. I've updated the docs to reflect the latest cloudfront changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped the notebooks for these URLs. This LGTM now

@jsignell jsignell merged commit 45c1ba2 into main Oct 18, 2023
1 check passed
@jsignell jsignell deleted the fix/dev-api-links branch October 18, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants