Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipeline Utils Unit Tests #158

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Add Pipeline Utils Unit Tests #158

merged 6 commits into from
Jun 20, 2024

Conversation

stephenkilbourn
Copy link
Contributor

Summary: Summary of changes

Addresses
veda-data-airflow #152 : Add unit tests around utils functions in veda_data_pipeline/utils

Changes

Bring in requests_mock to mock out calls to /token and /ingestions endpoints
add test files for each of the three utilities
test the dry run path and the "live" path using moto to mock api calls to aws

This gets coverage to the directory to 75%
Screenshot 2024-05-30 at 4 50 41 PM

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

Copy link
Contributor

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with one change to keep the test requirements separate from the dag requirements constraints for mwaa

dags/requirements-constraints.txt Outdated Show resolved Hide resolved
@anayeaye
Copy link
Contributor

Also: I learned about capsys from this PR. Thank you @stephenkilbourn!

@smohiudd smohiudd self-requested a review June 12, 2024 05:34
@smohiudd smohiudd merged commit 1238ff1 into dev Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants