-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth dot gov carousel #149
Conversation
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The carousel generally works, but a few things need fixing:
-
The link to sealevel does not work (see comment). A trailing slash seems to fix it.
-
There seem to be a bunch of very similar sealevel media images added - are they all needed?
-
The carousel needs to be better aligned with the title above it and other elements on the page, perhaps by using the grid differently. We might need to ping an engineer to help fix this - on first look, it is not obvious to me how.
Co-authored-by: Jonas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the links now work and alignment is decent.
On the home page, it looks a bit busy with different width blocks. But unless you can make the Carousel a couple of columns wider to match the elements above, I think there is no better way of handling these different elements.
Not sure the new (8f8f3f5) alignment of the carousel title on the home page is better. Not much to do, I guess? |
I adjusted the width of the carousel grid so that it matches the rest of the grid for the page. This can be also configured on a per-instance basis using a USWDS config file to override the default width / spacings of the grid, but i haven't tried it so far in the instances (Docs: https://designsystem.digital.gov/documentation/settings/#configuring-custom-uswds-settings) Hope this works? |
Nice! The carousel is massive now - could we also make both the carousel and its title have the same width as the elements above? |
@j08lue Okay, I replaced some of the legacy grid styles with the USWDS grid. There might be some minor differences in the width of the grid or some spacings from before (e.g the hero description might have been 50px wider before due to using legacy grid), but otherwise it should be okay. If anything, it can be easily tweaked now using some of the USWDS classes for spacing: https://designsystem.digital.gov/utilities/margin-and-padding/ |
Why are you creating this Pull Request?
With a global sea level portal we have been requested to add another link to highlight the new portal. Since we have 3 featured portals we requested integration of the carousel feature for Earth.gov. This PR configures the carousel as requested by HQ leadership