Added ability to deny unfiltered historical queries if new config opt… #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion "denyUnfilteredQueries" is defined or true. New option is a sub-option of sessions.historicalSessionFilter
jvigliotta
requested changes
Jul 25, 2024
davetsay
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Hi @chesterhawkins . thanks so much for contributing. I have one more slight change. I added a code suggestion to also check for the disable prop not being true. If it is false we shouldn't care about the denyUnfilteredQueries prop.
|
davetsay
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #175
New config option sessions.historicalSessionFilter. denyUnfilteredQueries is used to determine whether an unfiltered historical query should be denied or allowed.