Full angular removal #170
Full angular removal #170
Conversation
mergin main
…consistent with previous functionality
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Wow good stuff. That's a bunch of work. I made some suggestions and had some questions.
- I think we should just be consistent and remove the
this._openmctreferences. - We may want to file a follow up to improve venues, but should first find out how they really should work properly.
- Do any unit tests need updating?
- One thing i know was used in legacy repo, was the Data Product viewer, so let's test that.
| }; | ||
| }, | ||
| watch: { | ||
| filter: { |
There was a problem hiding this comment.
i think we should leverage Vue to do front end filtering. I think what is happening here is we are watching for changes in filters, setting a timeout which probably has something to do with user typing speed, and then applying the filter, which is a back end filtered request.
Going further if we use the core telemetry table component, we'd have built in front end filtering.
Going even further, we probably should be using the existing historical session selector.
There was a problem hiding this comment.
Also, you can pretty much ignore my comment above.
Venues in general don't need to be a main focus for this PR. We can get this in and improve venues down the road.
| 'packetSummaryEventStreamUrl', | ||
| 'commandEventUrl', | ||
| 'commandEventStreamUrl', | ||
| 'messageStreamUrl', | ||
| 'frameSummaryStreamUrl', | ||
| ]; |
There was a problem hiding this comment.
does some stuff need to be back ported into the constants file?
closes #108
This PR removes any remaining legacy code (openmct-legacy-support and angular mainly).