Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Plan Snapshots #1088

Merged
merged 8 commits into from
Aug 21, 2023
Merged

User Plan Snapshots #1088

merged 8 commits into from
Aug 21, 2023

Conversation

Mythicaeda
Copy link
Contributor

@Mythicaeda Mythicaeda commented Aug 10, 2023 •
edited
Loading

  • Tickets addressed: Closes Plan snapshots #884
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

  • The ability to create plan snapshots has been exposed to the user via a Hasura function.
  • Another hasura function was made to allow for restoring a plan to a snapshot

Verification

  • PermissionsTests were updated to include the two new function permission keys
  • RestoringSnapshot DBTests were added to PlanCollaborationTests

Documentation

A docs ticket has been made for the API docs changes needs
The new keys need to be included in #993 and in the User-Facing Permissions docs

Future work

@Mythicaeda Mythicaeda added the database Anything related to the database label Aug 10, 2023
@Mythicaeda Mythicaeda self-assigned this Aug 10, 2023
@Mythicaeda Mythicaeda requested a review from a team as a code owner August 10, 2023 16:51
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 16:51 — with GitHub Actions Inactive
@camargo camargo added the feature A new feature or feature request label Aug 10, 2023
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 18:57 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 18:57 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 19:03 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 19:03 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 19:03 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 20:11 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 20:11 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 10, 2023 20:11 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 15, 2023 19:46 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 15, 2023 19:46 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 15, 2023 19:46 — with GitHub Actions Inactive
skovati
skovati reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me so far! I'll do a final approval review tomorrow once this is rebased on top of #1041.

merlin-server/sql/merlin/functions/public/restore_from_snapshot.sql Show resolved Hide resolved
merlin-server/sql/merlin/tables/plan_snapshot.sql Show resolved Hide resolved
merlin-server/sql/merlin/tables/plan_snapshot.sql Outdated Show resolved Hide resolved
deployment/hasura/metadata/databases/AerieMerlin/tables/public_plan_snapshot_activities.yaml Outdated Show resolved Hide resolved
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:15 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:15 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:15 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:38 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:38 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 22:38 — with GitHub Actions Inactive
skovati
skovati approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some nonblocking comments, none of them would change functionality.

merlin-server/sql/merlin/tables/plan_snapshot.sql Show resolved Hide resolved
merlin-server/sql/merlin/functions/public/restore_from_snapshot.sql Outdated Show resolved Hide resolved
deployment/hasura/metadata/databases/AerieMerlin/tables/public_plan_snapshot_activities.yaml Outdated Show resolved Hide resolved
merlin-server/sql/merlin/functions/hasura/snapshot_functions.sql Show resolved Hide resolved
merlin-server/sql/merlin/functions/hasura/snapshot_functions.sql Show resolved Hide resolved
merlin-server/sql/merlin/functions/public/restore_from_snapshot.sql Outdated Show resolved Hide resolved
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:01 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:01 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:01 — with GitHub Actions Inactive
@Mythicaeda
Alter Plan Snapshot Table
f5eb104 
- Update Hasura Metadata
@Mythicaeda
Add override for create_snapshot
b89936f
@Mythicaeda
Add Restore Snapshot Functionality
feb0af8
@Mythicaeda
Add Hasura function for taking/restoring snapshots
ac0ea6d
@Mythicaeda
Add create_snapshot and restore_snapshot to `function_permission_…
e0cd866 
…key`

- Add new keys to `user_role_permission`
- Alphabetizes the JSONs
@Mythicaeda
Update Hasura Functions Metadata
ad5f9de 
- alphabetize functions.yaml
@Mythicaeda
Update PermissionsTest
325b606 
- Add new keys/cases
- Alphabetize `getFunctionReturnsAssignedValueUser`
- Correct `testMissionModel` to `testMissionModelOwner`
@Mythicaeda
Add DBTests
cd15ed5
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:18 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:18 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test August 18, 2023 23:18 — with GitHub Actions Inactive
@skovati
Copy link
Contributor

skovati commented Aug 19, 2023

🚀

@Mythicaeda Mythicaeda merged commit 4a8e144 into develop Aug 21, 2023
9 checks passed
@Mythicaeda Mythicaeda deleted the feat/user-plan-snapshots branch August 21, 2023 15:18
@camargo camargo mentioned this pull request Aug 21, 2023
Merged
@Mythicaeda Mythicaeda added the breaking change A change that will require updating downstream code label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skovati skovati skovati approved these changes

@mattdailis mattdailis Awaiting requested review from mattdailis

Assignees

@Mythicaeda Mythicaeda

Labels
breaking change A change that will require updating downstream code database Anything related to the database feature A new feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan snapshots
3 participants
@Mythicaeda @skovati @camargo