Test simulation input directives invariance

NASA-AMMOS · Nov 23, 2024 · c2e20c2 · c2e20c2
1 parent b97f551
commit c2e20c2
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/...nanation/src/main/java/gov/nasa/jpl/aerie/banananation/activities/GrowBananaActivity.java b/...nanation/src/main/java/gov/nasa/jpl/aerie/banananation/activities/GrowBananaActivity.java
@@ -40,7 +40,7 @@ public boolean validateGrowingDuration() {
   @EffectModel
   @ControllableDuration(parameterName = "growingDuration")
   public void run(final Mission mission) {
-    final var rate = this.quantity() / (double) this.growingDuration().in(Duration.SECONDS);
+    final var rate = this.quantity() / (double) this.growingDuration().ratioOver(Duration.SECOND);
     mission.fruit.rate.add(rate);
     delay(this.growingDuration());
     mission.fruit.rate.add(-rate);

diff --git a/scheduler-driver/src/test/java/gov/nasa/jpl/aerie/scheduler/EditablePlanTest.java b/scheduler-driver/src/test/java/gov/nasa/jpl/aerie/scheduler/EditablePlanTest.java
@@ -198,4 +198,35 @@ public void simResultMarkedNotStaleAfterRollback_SimulateThenCommit() {
 
     assertFalse(simResults.isStale());
   }
+
+  @Test
+  void simulationInputDirectivesDontChange() {
+    plan.create(
+        "BiteBanana",
+        new DirectiveStart.Absolute(Duration.MINUTE),
+        Map.of("biteSize", SerializedValue.of(1))
+    );
+
+    final var expectedDirectives = plan.directives();
+    final var simResults = plan.simulate();
+
+    plan.create(
+        "GrowBanana",
+        new DirectiveStart.Absolute(Duration.HOUR),
+        Map.of(
+            "growingDuration", SerializedValue.of(10000),
+            "quantity", SerializedValue.of(1)
+        )
+    );
+
+    assertIterableEquals(expectedDirectives, simResults.inputDirectives());
+    assertNotEquals(plan.directives(), simResults.inputDirectives());
+
+    plan.commit();
+
+    assertIterableEquals(expectedDirectives, simResults.inputDirectives());
+    assertNotEquals(plan.directives(), simResults.inputDirectives());
+
+    assertIterableEquals(plan.directives(), plan.simulate().inputDirectives());
+  }
 }