Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content onboarding scripts #26

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Conversation

mpoelchau
Copy link
Contributor

Copy link
Contributor

@childers childers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these seem to be working fine

Vagrantfile Outdated
Comment on lines 228 to 230
#Add tools to PATH
export PATH=$PATH:/home/vagrant/wiggle-tools:/home/vagrant/bam_to_bigwig:/home/vagrant/content_onboarding_scripts/bin:/home/vagrant/jbrowse/bin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only sets $PATH for the active session. Once we reset the session, this $PATH is lost.

Vagrantfile Outdated
mkdir -p /app/data/tools

#Add tools to PATH
export PATH=$PATH:/home/vagrant/wiggle-tools:/home/vagrant/bam_to_bigwig:/home/vagrant/content_onboarding_scripts/bin:/home/vagrant/jbrowse/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to:
sed 's/PATH=/PATH=/home/vagrant/wiggle-tools:/home/vagrant/bam_to_bigwig:/home/vagrant/content_onboarding_scripts/bin:/home/vagrant/jbrowse/bin:/g' .bash_profile >.bash_profile

@childers childers merged commit 61e5ef4 into kenttools Oct 22, 2019
@childers childers deleted the content_onboarding_scripts branch October 22, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants