[move] mute clippy for type complexity, default warning, uppercase #20814
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
reviewed
Jan 8, 2025
| @@ -52,7 +52,7 @@ impl<T> Op<T> { | |||
| } | |||
|
|
|||
| /// A collection of resource and module operations on a Move account. | |||
| #[derive(Debug, Clone, Eq, PartialEq, Ord, PartialOrd)] | |||
| #[derive(Debug, Default, Clone, Eq, PartialEq, Ord, PartialOrd)] | |||
There was a problem hiding this comment.
oh no. Oh no. oh NOOOO.
CLIPPY WHYYYYYYYY
I'm so sorry Jordan but you have bumped up against one of my all-time pet-peeves with clippy.
Can you add a #[allow(clippy::new_without_default)] here instead? (I think that's the right flag).
There was a problem hiding this comment.
😆 yes I can do that
jordanjennings-mysten
force-pushed
the
move-binary-crate-type-complexity-clippy
branch
from
d3df3a9 to
8966b43
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
changed the title
jordanjennings-mysten
changed the title
tzakian
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.