[indexer-alt] Add tests for obj_info pruner #20809
Open
+233
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/indexer-alt-obj-info-pruner-tests
branch
from
3933a24 to
9cedb9c
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
reviewed
Jan 8, 2025
7 tasks
lxfind
force-pushed
the
xun/indexer-alt-obj-info-pruner-tests
branch
from
9cedb9c to
0d5e0a2
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
changed the base branch from
main
to
xun/indexer-alt-obj-info-support-consensus-v2
wlmyng
approved these changes
Jan 9, 2025
| @@ -216,11 +254,31 @@ mod tests { | |||
| let result = obj_info.process(&Arc::new(checkpoint3)).unwrap(); | |||
| assert_eq!(result.len(), 1); | |||
| let processed = &result[0]; | |||
| assert_eq!(processed.cp_sequence_number, 3); | |||
| assert_eq!(processed.cp_sequence_number, 2); | |||
There was a problem hiding this comment.
noob q but how come this isn't 3, since the transfer object occurs in checkpoint 3 and qualifies to be inserted into values/processed?
There was a problem hiding this comment.
ah the checkpoint builder starts from 0
| #[test] | ||
| fn test_process_wrap() { | ||
| #[tokio::test] | ||
| async fn test_process_wrap() { |
| #[test] | ||
| fn test_process_object_owned_object() { | ||
| #[tokio::test] | ||
| async fn test_process_object_owned_object() { |
There was a problem hiding this comment.
should we also add a pruning component to this test?
| #[test] | ||
| fn test_process_consensus_v2_object() { | ||
| #[tokio::test] | ||
| async fn test_process_consensus_v2_object() { |
There was a problem hiding this comment.
and same here - i think the result is the first entry gets pruned right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.