Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-44] Lecture 테이블 pk 수정 반영 #285

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

5uhwann
Copy link
Member

@5uhwann 5uhwann commented Nov 20, 2024

✅ 작업 내용

  • Lecture 테이블의 pk를 lecture코드로 변경

🤔 고민 했던 부분

  • Lecture 테이블의 id를 정수형으로 유지할 경우 새로운 학기 시작 시 Lecture 테이블 로우의 변경의 관계를 맺는 모든 테이블에 전파된다는 점 때문에 id가 아닌 또다른 고유값인 lectureCode를 pk로 사용했습니다.

🔊 도움이 필요한 부분!!

@5uhwann 5uhwann added ♻️ refactor 기본의 로직 변경 없이 코드 개선 D-0 labels Nov 20, 2024
@5uhwann 5uhwann requested review from tiemo0708 and k-kbk November 20, 2024 16:29
@5uhwann 5uhwann self-assigned this Nov 20, 2024
Copy link

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 70.09346% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.54%. Comparing base (6b07cb9) to head (1c85415).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ation/service/CalculateMajorGraduationService.java 52.54% 27 Missing and 1 partial ⚠️
...yongjigraduatebe/lecture/domain/model/Lecture.java 92.00% 1 Missing and 1 partial ⚠️
...e/graduation/api/dto/response/LectureResponse.java 0.00% 1 Missing ⚠️
...tebe/lecture/api/dto/response/LectureResponse.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #285      +/-   ##
=============================================
+ Coverage      83.51%   83.54%   +0.02%     
- Complexity       580      581       +1     
=============================================
  Files            152      152              
  Lines           2438     2418      -20     
  Branches          87       87              
=============================================
- Hits            2036     2020      -16     
+ Misses           356      352       -4     
  Partials          46       46              
Files with missing lines Coverage Δ
...aduatebe/graduation/domain/model/ChapelResult.java 100.00% <100.00%> (ø)
...be/graduation/domain/model/GraduationCategory.java 77.77% <ø> (ø)
...monculture/CommonCultureDetailCategoryManager.java 98.50% <100.00%> (-0.09%) ⬇️
...service/commonculture/CommonGraduationManager.java 100.00% <100.00%> (ø)
...ecture/api/dto/response/SearchLectureResponse.java 94.44% <100.00%> (-0.80%) ⬇️
...cture/application/service/FindLecturesService.java 100.00% <ø> (ø)
...adapter/persistence/LecturePersistenceAdapter.java 100.00% <100.00%> (ø)
...e/adapter/persistence/entity/LectureJpaEntity.java 100.00% <100.00%> (ø)
...ture/adapter/persistence/mapper/LectureMapper.java 100.00% <ø> (ø)
...persistence/repository/LectureQueryRepository.java 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b07cb9...1c85415. Read the comment docs.

---- 🚨 Try these New Features:

@5uhwann 5uhwann merged commit ebd657a into develop Nov 20, 2024
4 of 5 checks passed
@5uhwann 5uhwann deleted the refactor/DEV-44 branch November 20, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-0 ♻️ refactor 기본의 로직 변경 없이 코드 개선 size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant