Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radio type and fixed mime type support and theme support #3

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

AIIX
Copy link
Contributor

@AIIX AIIX commented Aug 20, 2021

Description

  • Adds support for fixed mime types that Skills can send to open that specific player type ["type/video", "type/audio", "type/radio"]
  • Adds support for getting theme from play() metadata and forwarding it to playback skill if available
  • Adds support to display radio type

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

For Testing: MycroftAI/skill-npr-news#120
Requires: MycroftAI/skill-playback-control#49

CLA

  • Yes

Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, happy to add this in its current form, potentially with the theme item optional, so that any Skills that want to use it can do so and Skills still using the (track, mime) format won't break it.

What do you think?

plugin_playback_guiplayer/__init__.py Outdated Show resolved Hide resolved
@krisgesling krisgesling merged commit 3c9efbe into MycroftAI:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants