Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging #42

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactor logging #42

wants to merge 16 commits into from

Conversation

chrisveilleux
Copy link
Member

Description

Add a logging configuration that:

  • Rotates log files at midnight
  • Keeps two weeks worth of rotated log files
  • Defines a format for log messages, including the file and function that generated the message
  • Writes to log files instead of stdout

Converted all calls to the old logger to use the new logger and edited some log levels.

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Ensure that the log messages are being written to files in /var/log/mycroft

Documentation

The new logging configuration code is documented.

@synesthesiam synesthesiam removed their request for review January 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant