Remove cached assets (#4046)

* Remove cached assets not on the asset list anymore

* Simplify code

* Add test

* Improve test

src/services/Store/store/asset.slice.test.ts

@@ -72,6 +72,25 @@ describe('AccountSlice', () => {
     expect(actual).toEqual(expected);
   });
 
+  it('addFromAPI(): merges current assets with new assets', () => {
+    const a1 = fAssets[10];
+    const a2 = fAssets[11];
+    const a3 = {
+      ...fAssets[2],
+      isCustom: true
+    };
+    const a4 = fAssets[0];
+    const state = [a1, a2, a3, a4];
+    const modifiedEntities = [
+      { ...a1, contractAddress: '0xchanged' },
+      { ...a2, contractAddress: '0xchanged1' }
+    ];
+    const newAssets = modifiedEntities.reduce((acc, cur) => ({ ...acc, [cur.uuid]: cur }), {});
+    const actual = reducer(state, addAssetsFromAPI(newAssets));
+    const expected = [a3, a4, ...modifiedEntities];
+    expect(actual).toEqual(expected);
+  });
+
   it('reset(): can reset', () => {
     const entity = { uuid: 'random', contractAddress: '0x0' } as ExtendedAsset;
     const state = [entity];

src/services/Store/store/asset.slice.ts

@@ -4,6 +4,7 @@ import { all, call, put, takeLatest } from 'redux-saga/effects';
 import { EXCLUDED_ASSETS } from '@config';
 import { MyCryptoApiService } from '@services';
 import { ExtendedAsset, LSKeys, Network, NetworkId, TUuid } from '@types';
+import { arrayToObj } from '@utils';
 import { filter, findIndex, map, mergeRight, pipe, propEq, toPairs } from '@vendor';
 
 import { initialLegacyState } from './legacy.initialState';
@@ -41,9 +42,8 @@ const slice = createSlice({
       });
     },
     addFromAPI(state, action: PayloadAction<Record<string, ExtendedAsset>>) {
-      const currentAssets = state.reduce(
-        (acc, a: ExtendedAsset) => ({ ...acc, [a.uuid]: a }),
-        {} as Record<string, ExtendedAsset>
+      const currentAssets = arrayToObj('uuid')(
+        state.filter((a) => a.isCustom || a.type === 'base')
       );
       const mergeAssets = pipe(
         (assets: Record<TUuid, ExtendedAsset>) => mergeRight(currentAssets, assets),