Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Athena Connector #83

Merged
merged 26 commits into from
May 15, 2024
Merged

feat: Added Athena Connector #83

merged 26 commits into from
May 15, 2024

Conversation

TivonB-AI2
Copy link
Collaborator

@TivonB-AI2 TivonB-AI2 commented Apr 26, 2024 •
edited
Loading

Description

Added AWS Athena Connector for onboarding

Related Issue

https://linear.app/ai-squared/issue/AIS-25/day-2-4-gain-practical-experience-with-multiwoven-integrations

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

Using Ruby on Rails to check the connector based on multiwoven protocol

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@TivonB-AI2 TivonB-AI2 self-assigned this Apr 26, 2024
@afthabvp afthabvp requested a review from subintp April 30, 2024 12:27
arp99 pushed a commit to arp99/multiwoven that referenced this pull request May 3, 2024
@subintp
feat: source/databricks (Multiwoven#83)
2f0cb37 
* add databricks driver path

* add databricks client

* fix documentation url

* implement check_connection

* add negative test for connection

* add read method

* add discover

* bump version

* make catalog and schema required
@TivonB-AI2 TivonB-AI2 marked this pull request as ready for review May 9, 2024 12:16
@karthik-sivadas karthik-sivadas requested review from subintp and removed request for subintp May 14, 2024 19:59
@TivonB-AI2 TivonB-AI2 requested a review from subintp May 14, 2024 21:07
@afthabvp afthabvp self-requested a review May 15, 2024 09:33
@karthik-sivadas karthik-sivadas merged commit 946d9db into main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthik-sivadas karthik-sivadas karthik-sivadas approved these changes

@subintp subintp subintp approved these changes

@afthabvp afthabvp afthabvp approved these changes

Assignees

@TivonB-AI2 TivonB-AI2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TivonB-AI2 @afthabvp @subintp @karthik-sivadas