Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source_defined_cursor default value to false in stream #50

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: source_defined_cursor default value to false in stream #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ GIT
PATH
remote: .
specs:
multiwoven-integrations (0.1.58)
multiwoven-integrations (0.1.59)
activesupport
async-websocket
csv
Expand Down
2 changes: 1 addition & 1 deletion integrations/lib/multiwoven/integrations/protocol/protocol.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class Stream < ProtocolModel
attribute? :supported_sync_modes, Types::Array.of(SyncMode).optional.default(["incremental"])

# Applicable for database streams
attribute? :source_defined_cursor, Types::Bool.default(false).optional
attribute :source_defined_cursor, Types::Bool.default(false)
attribute? :default_cursor_field, Types::Array.of(Types::String).optional
attribute? :source_defined_primary_key, Types::Array.of(Types::Array.of(Types::String)).optional
attribute? :namespace, Types::String.optional
Expand Down
2 changes: 1 addition & 1 deletion integrations/lib/multiwoven/integrations/rollout.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module Multiwoven
module Integrations
VERSION = "0.1.58"
VERSION = "0.1.59"

ENABLED_SOURCES = %w[
Snowflake
Expand Down
4 changes: 3 additions & 1 deletion ...tions/lib/multiwoven/integrations/source/salesforce_consumer_goods_cloud/schema_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ def create_json_schema_for_object(metadata)
"json_schema": json_schema,
"required": required,
"supported_sync_modes": %w[incremental],
"source_defined_primary_key": [primary_key]
"source_defined_primary_key": [primary_key],
"source_defined_cursor": false,
"default_cursor_field": nil
}
end
end
Expand Down
2 changes: 2 additions & 0 deletions ...tions/spec/multiwoven/integrations/source/salesforce_consumer_goods/schema_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
expect(result[:json_schema]).to be_a(Hash)
expect(result[:required]).to contain_exactly("Field1")
expect(result[:supported_sync_modes]).to contain_exactly("incremental")
expect(result[:source_defined_cursor]).to eq(false)
expect(result[:default_cursor_field]).to eq(nil)
end
end
end
Loading