Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: changed finalize form width and color #33

Closed
wants to merge 33 commits into from
Closed

refactor: changed finalize form width and color #33

wants to merge 33 commits into from

Conversation

macintushar
Copy link
Member

Description

  • Changed Finalize Model screen to have same width and color as other screens

image

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

None

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@macintushar macintushar marked this pull request as ready for review April 12, 2024 04:16
@macintushar macintushar requested a review from sumitd94 April 12, 2024 04:16
@macintushar macintushar self-assigned this Apr 12, 2024
karthik-sivadas and others added 26 commits April 20, 2024 09:14
@karthik-sivadas @macintushar
fix: Update sync run mailer to trigger on failure only
12baa71
@karthik-sivadas @macintushar
fix: Code climate reporter path not found
bd07128
@sumitd94 @macintushar
fix: update back button navigation on syncs configuration (#35)
c65b2d8
@karthik-sivadas @macintushar
feat: Automate integrations gem release (#37)
632523b
@afthabvp @macintushar
feat: add protocol changes for cursor based (#38)
f418fbe
@sumitd94 @macintushar
feat: pull request template for monorepo (#39)
18f59f9
@karthik-sivadas @macintushar
feat: Remove changes associated with multiwoven-integrations reposito…
31b2f3a 
…ry (#41)
@macintushar
feat: added hover text for columns (#36)
e36ea2a
@karthik-sivadas @macintushar
feat: Add github action to deploy main (#44)
cfd20d2
@subintp @macintushar
Multiwoven release v0.3.0 (#46)
8262f4f 
Co-authored-by: github-actions <[email protected]>
@macintushar
fix: changed color for disabled Pagination button and cursor type (#42)
227b519
@afthabvp @macintushar
fix: add query_type in connector protocol
0880e91
@afthabvp @macintushar
fix: remove salesforce default cursor
1bb49b8
@afthabvp @macintushar
feat: add cursor based incremental refresh (#40)
bdaa8ad 
* feat: add cursor based incremental refresh

* feat: spec for CursorQueryBuilder

* fix: resolve pr comments

* fix: spec failure fixes

* fix: spec for default_cursor_field

* fix: soql cursor based query

* fix: test failures

* fix: pr comments resolved

* chore: update integrations version to 0.1.58

* fix: nitpick fix
@sumitd94 @macintushar
fix: sync creation process (#48)
19d981a 
* style: layout fix for the cross icon

* fix: persist state for sync mode
@afthabvp @macintushar
fix: source_defined_cursor default value to false in stream
e051776
@afthabvp @macintushar
chore: upgrade integrations 0.1.59
be016d8
@afthabvp @macintushar
fix: add source_defined_cursor in catalog
e9022d0
@afthabvp @macintushar
chore: upgrade integration to 0.1.60
997478f
@karthik-sivadas @macintushar
fix: Salesforce consumer goods cloud schema helper picklist type (#54)
c93f4a7
@karthik-sivadas @macintushar
Update integration gem version to 0.1.61
6e122c9
@sumitd94 @macintushar
feat: support for cursor field during syncs config (#43)
7a42d96
@afthabvp @macintushar
fix: salesforce query offset removed (#57)
d66e54d
@afthabvp @macintushar
fix: Add cursor-based exit condition in BatchQuery (#58)
d317a6c
@karthik-sivadas @macintushar
fix: Remove \n from rendered liquid template data
0326048
@karthik-sivadas @macintushar
fix rubocop error
9c437ce
karthik-sivadas and others added 6 commits April 20, 2024 09:14
@karthik-sivadas @macintushar
Revert "fix: Remove \n from rendered liquid template data" (#60)
c29088f
@karthik-sivadas @macintushar
fix: Add greater than zero validation for sync_interval (#61)
57e3136
@sumitd94 @macintushar
fix: update apply button condition for template mapping (#62)
675c061
@afthabvp @macintushar
fix: remove default cursor field from catalog (#63)
70d842a
@afthabvp @macintushar
feat: support cron expression in sync api (#66)
d7f1db0 
* feat: Add cron expression scheduler for sync

* fix: add schedule_type changes in sync controller and contract

* fix: add spec for sync contract

* fix: add cron_expression rspec

* fix: pr comments resolved

* fix: byebug removed

* fix: cron expression scheduler fix

* fix: spec failures
@sumitd94 @macintushar
fix: update scheduler type for manual interval (#67)
395d4bc
@macintushar macintushar deleted the refactor/models-finalize-screen branch April 20, 2024 03:45
@macintushar macintushar restored the refactor/models-finalize-screen branch April 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitd94 sumitd94 Awaiting requested review from sumitd94

Assignees

@macintushar macintushar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macintushar @karthik-sivadas @sumitd94 @afthabvp @subintp