chore(CE): add request response log for Airtable

Multiwoven · Aug 12, 2024 · fbd2c57 · fbd2c57
1 parent 8222794
commit fbd2c57
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 11 deletions.
diff --git a/integrations/Gemfile.lock b/integrations/Gemfile.lock
@@ -7,7 +7,7 @@ GIT
 PATH
   remote: .
   specs:
-    multiwoven-integrations (0.7.1)
+    multiwoven-integrations (0.7.7)
       activesupport
       async-websocket
       aws-sdk-athena

diff --git a/integrations/lib/multiwoven/integrations/destination/airtable/client.rb b/integrations/lib/multiwoven/integrations/destination/airtable/client.rb
@@ -59,10 +59,12 @@ def write(sync_config, records, _action = "create")
             connection_config = sync_config.destination.connection_specification.with_indifferent_access
             api_key = connection_config[:api_key]
             url = sync_config.stream.url
+            log_message_array = []
             write_success = 0
             write_failure = 0
             records.each_slice(MAX_CHUNK_SIZE) do |chunk|
               payload = create_payload(chunk)
+              args = [sync_config.stream.request_method, url, payload]
               response = Multiwoven::Integrations::Core::HttpClient.request(
                 url,
                 sync_config.stream.request_method,
@@ -74,6 +76,7 @@ def write(sync_config, records, _action = "create")
               else
                 write_failure += chunk.size
               end
+              log_message_array << log_request_response("info", args, response)
             rescue StandardError => e
               handle_exception(e, {
                                  context: "AIRTABLE:RECORD:WRITE:EXCEPTION",
@@ -82,13 +85,9 @@ def write(sync_config, records, _action = "create")
                                  sync_run_id: sync_config.sync_run_id
                                })
               write_failure += chunk.size
+              log_message_array << log_request_response("error", args, e.message)
             end
-
-            tracker = Multiwoven::Integrations::Protocol::TrackingMessage.new(
-              success: write_success,
-              failed: write_failure
-            )
-            tracker.to_multiwoven_message
+            tracking_message(write_success, write_failure, log_message_array)
           rescue StandardError => e
             handle_exception(e, {
                                context: "AIRTABLE:RECORD:WRITE:EXCEPTION",
@@ -119,7 +118,7 @@ def auth_headers(access_token)
           end
 
           def base_id_exists?(bases, base_id)
-            return if extract_data(bases).any? { |base| base["id"] == base_id }
+            return if extract_bases(bases).any? { |base| base["id"] == base_id }
 
             raise ArgumentError, "base_id not found"
           end

diff --git a/integrations/lib/multiwoven/integrations/rollout.rb b/integrations/lib/multiwoven/integrations/rollout.rb
@@ -2,7 +2,7 @@
 
 module Multiwoven
   module Integrations
-    VERSION = "0.7.1"
+    VERSION = "0.7.7"
 
     ENABLED_SOURCES = %w[
       Snowflake

diff --git a/integrations/spec/multiwoven/integrations/destination/airtable/client_spec.rb b/integrations/spec/multiwoven/integrations/destination/airtable/client_spec.rb
@@ -79,7 +79,7 @@
 
     it "returns a successful connection status if the request is successful" do
       allow(Multiwoven::Integrations::Core::HttpClient).to receive(:request).and_return(success_response)
-      allow(client).to receive(:extract_data).with(success_response).and_return([{ "id" => "app43WSzJbarW7bTX" }])
+      allow(client).to receive(:extract_bases).with(success_response).and_return([{ "id" => "app43WSzJbarW7bTX" }])
       message = client.check_connection(connection_config)
       expect(message).to be_a(Multiwoven::Integrations::Protocol::MultiwovenMessage)
       result = message.connection_status
@@ -88,7 +88,7 @@
 
     it "raises an error if the base idis not found in the response" do
       allow(Multiwoven::Integrations::Core::HttpClient).to receive(:request).and_return(success_response)
-      allow(client).to receive(:extract_data).with(success_response).and_return([{ "id" => "invalid" }])
+      allow(client).to receive(:extract_bases).with(success_response).and_return([{ "id" => "invalid" }])
       message = client.check_connection(connection_config)
       expect(message).to be_a(Multiwoven::Integrations::Protocol::MultiwovenMessage)
       result = message.connection_status
@@ -156,6 +156,12 @@
       message = client.write(sync_config, records)
       expect(message.tracking.success).to eq(2)
       expect(message.tracking.failed).to eq(0)
+      log_message = message.tracking.logs.first
+      expect(log_message).to be_a(Multiwoven::Integrations::Protocol::LogMessage)
+      expect(log_message.level).to eql("info")
+
+      expect(log_message.message).to include("request")
+      expect(log_message.message).to include("response")
     end
 
     it "increments the failure count" do
@@ -164,6 +170,12 @@
       message = client.write(sync_config, records)
       expect(message.tracking.success).to eq(0)
       expect(message.tracking.failed).to eq(2)
+      log_message = message.tracking.logs.first
+      expect(log_message).to be_a(Multiwoven::Integrations::Protocol::LogMessage)
+      expect(log_message.level).to eql("info")
+
+      expect(log_message.message).to include("request")
+      expect(log_message.message).to include("response")
     end
   end