Skip to content

Commit

Permalink
Resolve conflict in cherry-pick of 87c1fa2f2a8e15040c25d2028e51af933a…
Browse files Browse the repository at this point in the history
…c4f171 and change the commit message
  • Loading branch information
TivonB-AI2 authored and ai-squared committed Aug 21, 2024
1 parent 35350f3 commit 4d092f8
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 9 deletions.
4 changes: 4 additions & 0 deletions integrations/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ GIT
PATH
remote: .
specs:
<<<<<<< HEAD
multiwoven-integrations (0.8.4)
=======
multiwoven-integrations (0.8.6)
>>>>>>> 87c1fa2f (chore(CE): add request response log for SalesforceCrm (#344))
activesupport
async-websocket
aws-sdk-athena
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,15 @@ def initialize_client(config)
end

def process_records(records, stream)
log_message_array = []
write_success = 0
write_failure = 0
properties = stream.json_schema[:properties]
records.each do |record_object|
record = extract_data(record_object, properties)
process_record(stream, record)
request, response = *process_record(stream, record)
write_success += 1
log_message_array << log_request_response("info", request, response)
rescue StandardError => e
# TODO: add sync_id and sync_run_id to the logs
handle_exception(e, {
Expand All @@ -75,8 +77,9 @@ def process_records(records, stream)
sync_run_id: @sync_config.sync_run_id
})
write_failure += 1
log_message_array << log_request_response("error", request, e.message)
end
tracking_message(write_success, write_failure)
tracking_message(write_success, write_failure, log_message_array)
end

def process_record(stream, record)
Expand All @@ -86,7 +89,8 @@ def process_record(stream, record)
def send_data_to_salesforce(stream_name, record = {})
method_name = "#{@action}!"
args = build_args(@action, stream_name, record)
@client.send(method_name, *args)
response = @client.send(method_name, *args)
[args, response]
end

def build_args(action, stream_name, record)
Expand Down Expand Up @@ -116,12 +120,6 @@ def load_catalog
read_json(CATALOG_SPEC_PATH)
end

def tracking_message(success, failure)
Multiwoven::Integrations::Protocol::TrackingMessage.new(
success: success, failed: failure
).to_multiwoven_message
end

def log_debug(message)
Multiwoven::Integrations::Service.logger.debug(message)
end
Expand Down
4 changes: 4 additions & 0 deletions integrations/lib/multiwoven/integrations/rollout.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

module Multiwoven
module Integrations
<<<<<<< HEAD
VERSION = "0.8.4"
=======
VERSION = "0.8.6"
>>>>>>> 87c1fa2f (chore(CE): add request response log for SalesforceCrm (#344))

ENABLED_SOURCES = %w[
Snowflake
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@

expect(response.tracking.success).to eq(records.size)
expect(response.tracking.failed).to eq(0)
log_message = response.tracking.logs.first
expect(log_message).to be_a(Multiwoven::Integrations::Protocol::LogMessage)
expect(log_message.level).to eql("info")

expect(log_message.message).to include("request")
expect(log_message.message).to include("response")
end
end

Expand All @@ -117,6 +123,12 @@

expect(response.tracking.failed).to eq(records.size)
expect(response.tracking.success).to eq(0)
log_message = response.tracking.logs.first
expect(log_message).to be_a(Multiwoven::Integrations::Protocol::LogMessage)
expect(log_message.level).to eql("error")

expect(log_message.message).to include("request")
expect(log_message.message).to include("response")
end
end
end
Expand Down

0 comments on commit 4d092f8

Please sign in to comment.