Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Percentage property floating point issues #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OneYellowLemon
Copy link

Hello!

Sometimes, depending on the values of MaxTicks and CurrentTick, progress bars fails to complete due to floating point arithmetic issues.

Here is a screenshot from my debugger where the Percentage property should be 100, but is slightly off. This PR aims to fix that.
image

Code to reproduce:

const int max = 369;

ProgressBar progress = new ProgressBar(max, "test", new ProgressBarOptions
{
    ProgressBarOnBottom = true,
    BackgroundColor = ConsoleColor.DarkGray
});

for (int i = 0; i < max; i++)
{
    progress.Tick();
    Thread.Sleep(1);
}

Console.WriteLine($"Progress bar Percentage: {progress.Percentage}");
Console.WriteLine($"Progress bar CurrentTick and MaxTicks: {progress.CurrentTick} / {progress.MaxTicks}");

Tested with ShellProgressBar 5.2.0 and .NET 8.0.200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant