Fixes #671 Tray doesn't indicate private icon on when restoring #871
Conversation
There was a problem hiding this comment.
accept my sincere thank-you for volunteering to work on this. you saved me a bunch of time here 👍
I'm seeing a bit weirdness. while the original problem appears fixed (woo!), a few more bugs seem to have surfaced:
- UI can become unresponsive between switching modes,
- and URLs cannot be loaded.
seeing weirdness like this:
🏅 thanks again!
P.S. 1.1… we did it!!! go, @MozillaReality/fxr-eng team, et. al., go! 🔥🦊⏭ 🥅 🌟💥🌟💥✨
|
@cvan Does this patch cause these other issues or are they preexisting. If they are preexisting and this patch fixes the issue we should land it and file issues for the other bugs you have found. |
|
@bluemarvin it seems to regress, introduce bugs that did not appear before |
There was a problem hiding this comment.
I am unable to reproduce now after following my complete STR twice with master and twice with this branch.
the unresponsive UI was bad, but my logcat doesn't go that far back from 8 hours ago. (if you have any adb logcat tips, let me know.)
I'll assume what I saw was a fluke. I don't have any issues to block or file for yet. I'll keep an eye out.
|
@cvan I was trying to reproduce the issues following the email STRs but I couldn't. Let me know if you find other STRs otherwise feel free to merge if you feel confortable with this. |
Fixes #671 Tray doesn't indicate private icon on when restoring