Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#127] Add UserChip Component #147

Merged
merged 4 commits into from
Feb 2, 2024
Merged

[#127] Add UserChip Component #147

merged 4 commits into from
Feb 2, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Feb 1, 2024

#127

Changes

  • 유저 닉네임 표기에 사용할 칩 형태의 컴포넌트를 추가합니다.
  • 드롭다운 UI에 필요한 useOutsideClick 과 테스트를 추가합니다.
  • chakra-ui의 useOutsideClick 구현을 주로 참고하였습니다. (참고: chakra-ui/use-outside-click)
user-chip.mov

@2wheeh 2wheeh added ui Something about UI infra Infrastructure-related tasks and updates. labels Feb 1, 2024
@2wheeh 2wheeh self-assigned this Feb 1, 2024
isutare412
isutare412 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@2wheeh 2wheeh merged commit 1ee7470 into MovieReviewComment:develop Feb 2, 2024
1 check passed
@2wheeh 2wheeh deleted the feature/issue-127/user-chip branch February 2, 2024 06:16
@2wheeh 2wheeh mentioned this pull request Apr 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

@skgndi12 skgndi12 Awaiting requested review from skgndi12

Assignees

@2wheeh 2wheeh

Labels
infra Infrastructure-related tasks and updates. ui Something about UI
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2wheeh @isutare412