-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ✅ Fix race conditions in integration tests #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDemeco
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
TDemeco
reviewed
Dec 23, 2024
ffarall
changed the title
test: ✅ Fix race condition in
test: ✅ Fix race conditions in integration tests
Dec 23, 2024
skipTo
waiting for proof submissions…d `waitForMspResponseWithoutSealing`
…tch `advanceToBlock`, making it pass down the parameter
…ere's another in the pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
skipTo
waiting for proofs (eliminatedsleep
s).PaymentStreamCharged
events indebt-collection.test.ts
.respond-multi-requests.test.ts
.waitForTxInPool
.smile.jpg
towhatsup.jpg
inbsp-threshold.test.ts
to make it so thatBSP_DOWN
cannot immediately volunteer.bsp-threshold.test.ts
and make it deterministic which BSP should be volunteering first (that shouldn't change given that their IDs and the file keys of the files uploaded don't change ever).bsp-threshold.test.ts
where BSP was not yet synced with chain tip before waiting for volunteer.submit-proofs.test.ts
.storage-capacity.test.ts
where a transaction was submitted with the BSP key, but the BSP node had already submitted a transaction with the same nonce.