wip: 🚧 benchmark a few more extrinsics of the File System pallet #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
approved these changes
Dec 20, 2024
pallets/file-system/src/utils.rs
Outdated
| @@ -400,7 +400,6 @@ where | |||
|
|
|||
| if response == BucketMoveRequestResponse::Rejected { | |||
| <PendingBucketsToMove<T>>::remove(&bucket_id); | |||
There was a problem hiding this comment.
you could also just call this once since we delete it whether the msp rejects or accepts the request.
There was a problem hiding this comment.
I refactored this! Also the MoveBucketAccepted event was being emitted twice so I removed the call from utils.rs
ffarall
approved these changes
Dec 30, 2024
pallets/file-system/src/utils.rs
Outdated
| @@ -400,7 +400,6 @@ where | |||
|
|
|||
| if response == BucketMoveRequestResponse::Rejected { | |||
| <PendingBucketsToMove<T>>::remove(&bucket_id); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the benchmark code for
request_move_bucket,msp_respond_move_bucket_request,update_bucket_privacy,create_and_associate_collection_with_bucket,delete_bucket,bsp_volunteerand the partial setup forbsp_confirm_storing. To keep going with the rest of the extrinsics, a script to generate varios non-inclusion and inclusion forest proofs and file key proofs is needed, which is currently being worked on.