-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #611
Open
kam8818
wants to merge
316
commits into
MobileChromeApps:android-service-take-2
Choose a base branch
from
kam8818:master
base: android-service-take-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did this already when webview=system in manifest.mobile.json. This fixes when --webview=system is passed on command-line
…'t uninstall correctly (fixes MobileChromeApps#488) This works around a bug in Cordova: https://issues.apache.org/jira/browse/CB-8236
…rsions As per https://developer.android.com/google/gcm/client.html, it's not required past 4.0.4
…messages This technique is specified by the GCM guide: https://developer.android.com/google/gcm/client.html
…eChromeApps#491) This also refactors the Android implementation quite a bit, and fixes up some of the Play Services error flows. This also removes the JS caching of access tokens for non-web flows (native side caches them better anyways). Adds some new tests for testing custom scopes.
…reate-spec.sh script Also adds a consistent debug signing key for chrome-apps-api-tests so that identity & gcm tests can always pass.
…roperty Without this, writes to a device I'm testing fail. Responses are provided through characteristic changed notifications.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c