Community board options are displayed for Picos (#1711)

* Community board options are displayed for Picos * Updated comments in code * Fixed comment
MobiFlight · Feb 23, 2024 · 821e24a · 821e24a
1 parent d4364e1
commit 821e24a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/MobiFlight/BoardDefinitions.cs b/MobiFlight/BoardDefinitions.cs
@@ -33,6 +33,18 @@ public static Board GetBoardByUsbVolumeLabel(String volumeLabel)
             return boards.Find(board => board.UsbDriveSettings?.VolumeLabel == volumeLabel);
         }
 
+        /// <summary>
+        /// Finds board definitions by matching against USB drive volume label. This does not check for the
+        /// presence of a secondary file on the drive to confirm it is a supported USB drive.
+        /// This is used for offering different community board options.
+        /// </summary>
+        /// <param name="volumeLabel">The volume label to match</param>
+        /// <returns>All board definitions matching the volumeLabel, or an empty list if none found.</returns>
+        public static List<Board> GetBoardsByUsbVolumeLabel(String volumeLabel)
+        {
+            return boards.FindAll(board => board.UsbDriveSettings?.VolumeLabel == volumeLabel);
+        }
+
         /// <summary>
         /// Finds a board definition by matching against the USB VID/PID.
         /// </summary>

diff --git a/UI/Panels/Settings/MobiFlightPanel.cs b/UI/Panels/Settings/MobiFlightPanel.cs
@@ -324,16 +324,13 @@ private void UpdateToolbarAndPanelAfterNodeHasChanged(TreeNode node)
 
             if (!isMobiFlightBoard)
             {
-                // TODO: Show an option to upload the VID PID compatible firmwares
                 var boards = BoardDefinitions.GetBoardsByHardwareId(module.HardwareId);
 
-                // we don't have ambiguous boards
                 // but we have a device like the pico
                 if (boards.Count == 0 && module.Board.UsbDriveSettings != null) 
                 {
-                    // at the moment we don't support
-                    // alternatives for the USB type device
-                    boards.Add(module.Board);
+                    // find all alternatives for the USB type device
+                    boards = BoardDefinitions.GetBoardsByUsbVolumeLabel(module.HardwareId);
                 }
 
                 if (boards.Count > 0)