Extend slow query threshold to reduce logs #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riku6460
approved these changes
Oct 6, 2023
|
焼き上がり待ち |
|
Kudos, SonarCloud Quality Gate passed!
|
u1-liquid
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
クエリが slow であると判定される閾値を 300ms から 10s に伸ばします。
Why
300ms を閾値とすると、あまりに多くのクエリが slow 判定され、あまりに多くの slow query log が出力されてしまい、パフォーマンス分析の際にノイズになるため。
io では pg_stat_statements 等を用いて slow query を分析できるため、アプリケーションレベルで閾値の厳しいログを吐く意味はない。