PRODENG-2778 TF and test fix #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
james-nesbitt
commented
Nov 1, 2024
james-nesbitt
commented
- Terraform fix for latest upstream provision
- smoke and integration test fix for upstream provision
- some go fmt (kubeclient)
- Terraform fix for latest upstream provision - smoke and integration test fix for upstream provision Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2778-smoke-test-fix
branch
from
9e55faf to
3be2cf4
Compare
james-nesbitt
commented
Nov 1, 2024
cranzy
reviewed
Nov 4, 2024
| @@ -1,14 +1,14 @@ | |||
| // used to name infrastructure (CHANGE THIS) | |||
| name = "smoke-test" | |||
| #name = "mcc-smoke-test" | |||
There was a problem hiding this comment.
does this need to be commented out ?
There was a problem hiding this comment.
both you and @pgedara questioned this so I reverted it.
Note that this line is not used by the integration testing, and should likely be a .tfvar.template file. That string name is a bad idea because many consumers will use it without changing the name, meaning that we end up with untraceable orphans and conflicts.
This cleanup can be done in another effort, when it is not blocking this much needed fix to the mcc GH PR tests.
james-nesbitt
commented
Nov 4, 2024
cranzy
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.