Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRODENG-2528 allow force mcr upgrade #420

Merged

Conversation

james-nesbitt
Copy link
Collaborator

This allows a command argument which will force the MCR upgrade phase to select all hosts, even if they look like they already match the requested version.

  • product.Product.Apply now accepts "force upgrade compatible products" flag
  • MKE product uses the flag in the upgrade MCR phase
  • if MCR upgrade phase recieves true for the flag, then all hosts get upgraded
  • cmd.Apply recieves a cli arg, and passes it as the "force upgrade" Product flag

https://mirantis.jira.com/browse/PRODENG-2528

Copy link
Collaborator

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for the conflict)

@james-nesbitt james-nesbitt force-pushed the PRODENG-2528-force-upgrade-mcr branch from 5ed1cb3 to 42b7124 Compare February 8, 2024 11:17
@james-nesbitt james-nesbitt force-pushed the PRODENG-2528-force-upgrade-mcr branch from 64a48fd to 688f54e Compare February 8, 2024 12:06
@kke
Copy link
Collaborator

kke commented Feb 8, 2024

  Error: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
  Error: File is not `gofumpt`-ed (gofumpt)
  Error: unnecessary trailing newline (whitespace)

golangci-lint run --fix should take care of these. ( go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest first)

This allows a command argument which will force the MCR upgrade phase
to select all hosts, even if they look like they already match the
requested version.

- product.Product.Apply now accepts "force upgrade compatible products" flag
- MKE product uses the flag in the upgrade MCR phase
- if MCR upgrade phase recieves true for the flag, then all hosts get
  upgraded
- cmd.Apply recieves a cli arg, and passes it as the "force upgrade"
  Product flag

Co-authored-by: Kimmo Lehto <[email protected]>
Signed-off-by: James Nesbitt <[email protected]>
@james-nesbitt james-nesbitt force-pushed the PRODENG-2528-force-upgrade-mcr branch from 688f54e to dcfcbab Compare February 8, 2024 13:03
@james-nesbitt
Copy link
Collaborator Author

conflict resolved

@james-nesbitt james-nesbitt merged commit 86a98b6 into Mirantis:master Feb 8, 2024
4 checks passed
@james-nesbitt james-nesbitt deleted the PRODENG-2528-force-upgrade-mcr branch November 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants