Merge pull request #195 from Mirantis/mandatorysecretkey

Mandatory SECRET_KEY

kqueen/config/dev.py

@@ -6,7 +6,7 @@ class Config(BaseConfig):
     LOG_LEVEL = 'DEBUG'
 
     # App secret
-    SECRET_KEY = 'secret'
+    SECRET_KEY = 'SecretSecretSecret123'
 
     # Jenkins engine settings
     JENKINS_API_URL = 'https://ci.mcp.mirantis.net'

kqueen/config/test.py

@@ -6,7 +6,7 @@ class Config(BaseConfig):
     LOG_LEVEL = 'DEBUG'
 
     # App secret
-    SECRET_KEY = 'secret'
+    SECRET_KEY = 'SecretSecretSecret123'
 
     # Etcd settings
     ETCD_PREFIX = '/kqueen_test'

kqueen/exceptions.py

@@ -0,0 +1,3 @@
+class ImproperlyConfigured(Exception):
+    """Kqueen is improperly configured"""
+    pass

kqueen/server.py

@@ -3,6 +3,7 @@
 from .blueprints.api.views import api
 from .blueprints.metrics.views import metrics
 from .config import current_config
+from .exceptions import ImproperlyConfigured
 from .middleware import setup_metrics
 from .serializers import KqueenJSONEncoder
 from .storages.etcd import EtcdBackend
@@ -38,6 +39,11 @@ def create_app(config_file=None):
     # load configuration
     config = current_config(config_file)
     config.setup_policies()
+
+    secret_key = config.get('SECRET_KEY')
+    if not secret_key or len(secret_key) < 16:
+        raise ImproperlyConfigured('The SECRET_KEY must be set and longer than 16 chars.')
+
     app.config.from_mapping(config.to_dict())
     app.logger.setLevel(getattr(logging, app.config.get('LOG_LEVEL')))
     app.logger.info('Loading configuration from {}'.format(config.source_file))