Fix numerous issues #816
Merged
Fix numerous issues #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerospiel
requested review from
Kshatrix,
eromanova and
a13x5
as code owners
zerospiel
force-pushed
the
fix_human_lint
branch
from
2e0fe22 to
921689c
Compare
* fix comment/naming (closes Mirantis#754) * comment isNonMajor, provide examples (closes Mirantis#753) * simplifie VerifyAPI (closes Mirantis#758) * enhance helmSpec String symbol (closes Mirantis#756) * simplified makeClientFromSecret (closes Mirantis#762) * renamed ArtifactReady and commented out (closes Mirantis#764) * added const for SA NS path in CurrentNamespace symbol (closes Mirantis#772) * isTemplateChainValid symbol: advice maps with the len (closes Mirantis#774) * validateReleaseWithValues symbol: simplify (closes Mirantis#776) * fix typo in test node name (closes Mirantis#783) * call linter from a single make target (closes Mirantis#796)
zerospiel
force-pushed
the
fix_human_lint
branch
from
921689c to
5e8f76b
Compare
eromanova
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProviderVSphereName. #754)isNonMajoris not safe for non-ascii #753)makeClientFromSecretcan be simplified #762)ArtifactReadyfunction signature can be simplified #764)make test#796)