-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup implementation: velero installation #815
base: main
Are you sure you want to change the base?
Conversation
bce8d98
to
e3ce508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question about the hmc.mirantis.com/component: hmc
label and credentials backup. As I understood only objects with this label will be backed up. But I'm concerned about the credentials' identity references. Our controller does not modify the identity refs (Secrets, AzureClusterIdentity, etc) when it was provided by the user. Maybe the credentials controller should be adjusted to label those objects too?
Also, please add this label on newly added config/dev/adoptedcluster-*.yaml
objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about the HelmCharts
and HelmRepositories
.
I haven't found any logic about labeling the generated HelmCharts (sorry if it's present and I've missed it).
When the user creates the BYO Template it can reference the helm chart from the custom HelmRepository
(manually created). Should it also be labeled?
Please ignore my concerns if it's something that you're aware but it's not in the scope of this PR.
e3ce508
to
ccb6d03
Compare
* new component labels on most components * wide range of new RBAC permission for the backup ctrl * velero stack reconciliation * adjusted backup user-facing roles * added backup ctrl configuration in the hmc chart * removed schema defaults in favor of mutation
ccb6d03
to
3a9a38a
Compare
Not quite, there will be many more label selectors, and those sentinel labels are just for objects that do not have any labels at the moment but should also be presented within a backup. One of the selectors also covers the In particular, the question about the |
Note: the controller is still turned off to avoid any potential regression.
#605