Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix azure.json generation: include node-subnet data #804

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix azure.json generation: include node-subnet data #804

merged 1 commit into from
Dec 23, 2024

Conversation

a13x5
Copy link
Contributor

@a13x5 a13x5 commented Dec 18, 2024

Fixes #730

@a13x5 a13x5 force-pushed the azure-nsg-fix branch 4 times, most recently from e6b1c79 to 5f5dac2 Compare December 18, 2024 14:30
@a13x5
Copy link
Contributor Author

a13x5 commented Dec 18, 2024

Tested with LB service with http-echo

> kubectl get svc
NAME           TYPE           CLUSTER-IP      EXTERNAL-IP    PORT(S)        AGE
http-echo-lb   LoadBalancer   10.103.26.121   13.64.251.61   80:32290/TCP   116s
kubernetes     ClusterIP      10.96.0.1       <none>         443/TCP        28m
> curl http://13.64.251.61
"heyyyy"

@a13x5 a13x5 marked this pull request as ready for review December 18, 2024 14:31
@a13x5 a13x5 self-assigned this Dec 18, 2024
@DinaBelova DinaBelova requested a review from eromanova December 23, 2024 15:14
@eromanova eromanova merged commit a494be5 into Mirantis:main Dec 23, 2024
5 checks passed
kylewuolle pushed a commit to kylewuolle/hmc that referenced this pull request Dec 23, 2024
@a13x5 @kylewuolle
Fix azure.json generation: include node-subnet data (Mirantis#804)
5a467e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova eromanova eromanova approved these changes

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

Assignees

@a13x5 a13x5

Labels
None yet
Projects
Project 2A
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure cloud provider only creates rules in the control plane NSG
2 participants
@a13x5 @eromanova