Add CAPI status/conditions to deployment status #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
force-pushed
the
capi-status
branch
from
c523202 to
856eaeb
Compare
kylewuolle
requested review from
Kshatrix,
slysunkin,
squizzi,
eromanova and
a13x5
Kshatrix
previously requested changes
Aug 27, 2024
squizzi
reviewed
Aug 27, 2024
eromanova
reviewed
Aug 27, 2024
kylewuolle
force-pushed
the
capi-status
branch
3 times, most recently
from
2eadd5c to
0d5a594
Compare
squizzi
reviewed
Aug 27, 2024
kylewuolle
force-pushed
the
capi-status
branch
2 times, most recently
from
53f8648 to
e95147a
Compare
kylewuolle
dismissed
Kshatrix’s stale review
I've made the changes but github doesn't detect this!
squizzi
reviewed
Aug 28, 2024
squizzi
previously requested changes
Aug 29, 2024
kylewuolle
dismissed
squizzi’s stale review
Github thinks the changes weren't made
kylewuolle
force-pushed
the
capi-status
branch
from
6a4777f to
cc422e3
Compare
|
@kylewuolle just need to rebase to get rid of this merge commit: 0635d50 and it lgtm |
squizzi
reviewed
Aug 29, 2024
kylewuolle
force-pushed
the
capi-status
branch
from
cc422e3 to
33d732b
Compare
kylewuolle
force-pushed
the
capi-status
branch
from
33d732b to
63bd2eb
Compare
kylewuolle
force-pushed
the
capi-status
branch
from
63bd2eb to
c12515a
Compare
squizzi
approved these changes
Aug 30, 2024
bnallapeta
pushed a commit
to bnallapeta/hmc
that referenced
this pull request
Nov 15, 2024
Add CAPI status/conditions to deployment status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #219. This PR adds a new function that fetches the CAPI status / conditions of the cluster and places them in the deployment status/conditions. To ensure the conditions are updated the controller now requeues until the CAPI cluster conditions are all true.