-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOP-951] Introduce dependencies for helm chart addons #92
Conversation
@@ -30,8 +30,9 @@ type ChartInfo struct { | |||
// +kubebuilder:validation:Required | |||
Version string `json:"version"` | |||
|
|||
Set map[string]intstr.IntOrString `json:"set,omitempty"` | |||
Values string `json:"values,omitempty"` | |||
DependsOn []string `json:"dependsOn,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be of type NamespacedObjectReference
so we can depend on a addon from another namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, FluxCD needs the HelmRelease
name and namespace. BOP generates all helm releases with the following values:
&helmv2.HelmRelease{
ObjectMeta: metav1.ObjectMeta{
Name: addon.Spec.Name,
Namespace: consts.NamespaceBoundlessSystem,
},
},
here the namespace is always blueprint-system
, and the release name is the addon name, so, all we need to allow dependencies between addons is the addon name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thought
Description
Allow specifying dependencies for helm chart addons. FluxCD supports dependencies and asks for the name and the namespace of the
HelmRelease
. In BOP, we create theHelmRelease
objects, so, in the blueprint, it's enough to specify the addon name without the need to set a namespace which is alwaysblueprint-system
.Testing
Deployed MKE Dashboard addon with nginx as in the dependencies, the blueprint looked like this
The resulting
HelmRelease