[BOP-251] Generate versioned manifest in CI #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwneisen
changed the title
| @@ -1,6305 +0,0 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Yes. It's generated in CI now so we don't have to keep it up to date and check it in. CI will always build and publish with the latest changes.
There was a problem hiding this comment.
I was wondering if it makes sense to keep it as we might need it for dev purposes especially when testing local changes when no CI is involved.
There was a problem hiding this comment.
The command still generates it locally. Someone making changes would need to run it anyway to get the latest changes. Not having it is more of a reminder to make sure someone runs the commands and tests locally with the latest changes
There was a problem hiding this comment.
okay. Sounds good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mirantis.jira.com/browse/BOP-251
I missed getting the semver and having CI generate the manifest before uploading it