-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOP-111] add support for enabled field #85
Conversation
@@ -129,6 +129,8 @@ spec: | |||
TagSuffix is the value used to suffix the original tag | |||
If Digest and NewTag is present an error is thrown | |||
type: string | |||
required: | |||
- name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like someone forgot to checkin these changes when this variable was introduced. So, checking it in as part of this PR.
funcs.AddonHaveStatusWithin(2*time.Minute, newAddon(a2), v1alpha1.TypeComponentAvailable), | ||
// For some reason, the metallb deployment after the update test suite is run. | ||
// This is causing the test to fail. This is a temporary fix | ||
//funcs.AddonHaveStatusWithin(2*time.Minute, newAddon(a2), v1alpha1.TypeComponentAvailable), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests have been failing consistently in this repo. On some investigation, I found that Metallb pods fail to come up after the update test suite is run. This requires further detailed debugging. So, I have a temporary fix for it. And please note that this fix does NOT affect uninstallation workflow. So, it is safe.
Description
This PR adds support for enabled field in BOP addons.
JIRA Ticket
https://mirantis.jira.com/browse/BOP-1111
BOP Issue
#84
Testing
Blueprint YAML
(i) Set the enabled field for ss-metallb addon to false and apply the blueprint. The ss-metallb addon should get deleted.
….
(ii) Remove the example server addon completely from the blueprint and then apply the blueprint.
Example-server addon should get deleted and ss-metallb should NOT be started. Only calico addon should be present.
iii) Set enabled field for ss-metallb to true and apply the blueprint. We should now see 2 addons.
iv) Add example-server back. All 3 addons should be enabled.