Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOP-1388] Add semver information to binary #102

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

nwneisen
Copy link
Collaborator

@nwneisen nwneisen commented Dec 12, 2024

https://mirantis.jira.com/browse/BOP-1388

Adds standard semver to the build images and binaries

Manual testing

Built all three images

nneisen: code/blueprint-operator - (BOP-1388) > docker images
REPOSITORY                                      TAG       IMAGE ID       CREATED              SIZE
ghcr.io/mirantiscontainers/blueprint-operator   1416dcc   84be1326f59f   6 seconds ago        96.4MB
ghcr.io/mirantiscontainers/blueprint-operator   v0.0.3    508dddcb8797   About a minute ago   96.4MB
ghcr.io/mirantiscontainers/blueprint-operator   dev       99dc3a6f183e   2 minutes ago        96.4MB

Run each image in a cluster
local dev image

│ {"level":"info","ts":"2024-12-13T00:49:30Z","logger":"setup","msg":"starting manager","version":"dev","commit":"021af9a","date":"

merge image:

 {"level":"info","ts":"2024-12-13T00:54:05Z","logger":"setup","msg":"starting manager","version":"1416dcc","commit":"1416dcc","date":"2024-12-12"}

release image:

{"level":"info","ts":"2024-12-13T00:51:57Z","logger":"setup","msg":"starting manager","version":"v0.0.3","commit":"021af9a","date":"2024-12-12"}

Notes

I didn't include the CI changes in this PR. I did change the image tag for now but I will revisit this later with the rest of the CI changes.

@nwneisen nwneisen requested review from RaunakShah, byDimasik and a team December 12, 2024 17:45
@nwneisen nwneisen changed the title Add semver information to binary [BOP-1388] Add semver information to binary Dec 12, 2024
@mirantiscontainers-bot
Copy link
Collaborator

mirantiscontainers-bot commented Dec 12, 2024

Coverage Report

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/mirantiscontainers/blueprint-operator 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/mirantiscontainers/blueprint-operator/main.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@nwneisen nwneisen merged commit 35b1935 into Mirantis:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants