Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Get access keys for account #410

Merged
merged 4 commits into from
Oct 16, 2023
Merged

RPC: Get access keys for account #410

merged 4 commits into from
Oct 16, 2023

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Oct 12, 2023

No description provided.

bh2smith
bh2smith approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I think those two extra tests could help out in the future.

packages/rpc/src/methods/keys.ts Show resolved Hide resolved
packages/rpc/src/methods/keys.test.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to production October 16, 2023 08:18 Inactive
@github-actions github-actions bot temporarily deployed to production October 16, 2023 09:13 Inactive
@github-actions github-actions bot temporarily deployed to production October 16, 2023 09:17 Inactive
@tifrel tifrel merged commit 2231d07 into beta Oct 16, 2023
5 checks passed
tifrel added a commit that referenced this pull request Oct 16, 2023
@tifrel
RPC: Get access keys for account (#410)
881c935
tifrel added a commit that referenced this pull request Oct 16, 2023
@tifrel
RPC: Get access keys for account (#410)
324c6ad
@tifrel tifrel deleted the rpc-active-keys branch February 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bh2smith bh2smith bh2smith approved these changes

@sainthiago sainthiago sainthiago approved these changes

@SurgeCode SurgeCode Awaiting requested review from SurgeCode SurgeCode is a code owner

@rubenmarcus rubenmarcus Awaiting requested review from rubenmarcus rubenmarcus is a code owner

@cif cif Awaiting requested review from cif

@microchipgnu microchipgnu Awaiting requested review from microchipgnu microchipgnu is a code owner

@nategeier nategeier Awaiting requested review from nategeier nategeier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tifrel @sainthiago @bh2smith