Unify/simplify pickles variable names #16376
Conversation
|
!ci-build-me |
volhovm
force-pushed
the
volhovm/rename-pickles-vars
branch
from
2611c47
to
37a4f1b
Compare
|
!ci-build-me |
| (** The challenge used for combining polynomials *) | ||
| ; bulletproof_challenges : 'bulletproof_challenges | ||
| (** The challenges from the inner-product argument that was partially verified. *) | ||
| ; b : 'fq | ||
| (** b = challenge_poly plonk.zeta + r * challenge_poly (domain_generrator * plonk.zeta) | ||
| (** b = challenge_poly plonk.zeta + evalscale * challenge_poly (domain_generrator * plonk.zeta) |
There was a problem hiding this comment.
domain_generator, might as well fix it while we are here
There was a problem hiding this comment.
Thanks for the review! Should it be generator?
There was a problem hiding this comment.
domain_generator is still widely used in mina? Or it should also be all renamed into generator?
There was a problem hiding this comment.
Oh no sry i mean that the typo domain_generrator in the comment should be domain_generator instead. I wanted to remove the extra "r"
|
!ci-nightly-me |
There was a problem hiding this comment.
This PR is a no-op except for potential serialization backwards compatibility, which I will look into.
This is my main concern. I think we have to be careful about whether / how the JSON serialisation for o1js etc. may change too, if that's used.
That said, this is great. I've wanted to make this change for years!
|
!ci-nightly-me |
This PR renames certain pickles variables for uniformity. For justification see o1-labs/proof-systems#2811
Concretely:
xi(also known aspolyscaleandu) becomespolyscaler(also known asevalscaleandvand randomness) becomesevalscaleThis PR is a no-op except for potential serialization backwards compatibility, which I will look into.