-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MV2 code from "Create an extension tutorial, part 1" #3277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Writer/Editor
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the content changes, but we need to update the samples repo to v3 at the same time.
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Outdated
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md
Show resolved
Hide resolved
Learn Build status updates of commit 8588c8b: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Dev
This PR is finished & on-hold waiting for Extensions repo Part 1 to be updated from MV2 to MV3, per PR: microsoft/MicrosoftEdge-Extensions#202
manifest.json
:https://github.com/microsoft/MicrosoftEdge-Extensions/blob/main/Extension%20samples/extension-getting-started-part1/part1/manifest.json --
"manifest_version": 2,
When that line becomes
"manifest_version": 3,
, this PR can be merged.Rendered articles for review:
part1-simple-extension.md
)part2-content-scripts.md
)extension-sideloading.md
)~/index.yml
)/developer/index.yml
)/extensions/landing/index.yml
)toc.yml
)AB#54090321