Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "Detached Elements" tool #3267

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Deprecate "Detached Elements" tool #3267

merged 7 commits into from
Sep 18, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Sep 16, 2024 •
edited
Loading

Rendered article for review:

AB#53967018

@mikehoffms mikehoffms added in-progress cat: devtools DevTools-related content. labels Sep 16, 2024
@mikehoffms mikehoffms changed the title Deprecate "Debug DOM memory leaks with the Detached Elements tool" Deprecate "Detached Elements" tool Sep 18, 2024
@mikehoffms mikehoffms marked this pull request as ready for review September 18, 2024 14:39
captainbrosset
captainbrosset approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small change request.

microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks.md Outdated Show resolved Hide resolved
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 3e36de1:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/memory-problems/dom-leaks.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 61eb5b5 into main Sep 18, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/detached-depr branch September 18, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikehoffms @captainbrosset