Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap snapshot objects categorized by property list in curly braces #3260

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Sep 3, 2024

Rendered article section for review:

This PR makes the following changes:

Sahar21170

This comment was marked as spam.

@mikehoffms mikehoffms marked this pull request as draft September 4, 2024 14:52
@mikehoffms mikehoffms added the cat: devtools DevTools-related content. label Sep 4, 2024
@mikehoffms mikehoffms marked this pull request as ready for review September 16, 2024 20:14
Copy link

Learn Build status updates of commit fcfed3b:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/customize-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/settings-icon.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/shallow-size-entire-object.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2022/06/devtools-103.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

@sethbrenith sethbrenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per dev review

Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per Writer/Editor review after changes were made.

@captainbrosset captainbrosset merged commit 4da19c4 into main Sep 19, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/heap-snapshot-categs branch September 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants