-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Focus Mode] New content and images for the Console DOM interaction article #2881
Merged
captainbrosset
merged 8 commits into
user/pabrosse/focus-mode-july-2023
from
user/pabrosse/focus-mode-console-dom
Oct 24, 2023
Merged
[Focus Mode] New content and images for the Console DOM interaction article #2881
captainbrosset
merged 8 commits into
user/pabrosse/focus-mode-july-2023
from
user/pabrosse/focus-mode-console-dom
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbrosset
added
cat: devtools
DevTools-related content.
focus-mode-screenshots
These PRs are about renewing screenshots in the DevTools docs for Focus Mode
labels
Oct 18, 2023
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
reviewed
Oct 19, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writer/Editor review pass 1
Co-authored-by: Michael Hoffman <[email protected]>
…23' into user/pabrosse/focus-mode-console-dom
mikehoffms
reviewed
Oct 23, 2023
microsoft-edge/devtools-guide-chromium/console/console-dom-interaction.md
Outdated
Show resolved
Hide resolved
mikehoffms
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writer/Editor 2nd review, entered 1 Suggestion comment
…eraction.md Co-authored-by: Michael Hoffman <[email protected]>
captainbrosset
merged commit Oct 24, 2023
2ee77e9
into
user/pabrosse/focus-mode-july-2023
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat: devtools
DevTools-related content.
focus-mode-screenshots
These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This article was using a learn.microsoft.com page for demos, which isn't great. If the site changes, we need to redo the article.
I created a new simple demo on our usual demos repo, and changed the article's content to match. I also updated all screenshots to match with Focus Mode.
Before: https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/console/console-dom-interaction
After: https://review.learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/console/console-dom-interaction?branch=pr-en-us-2881
AB#47125440