Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON viewer: removing the experimental flag and adding a note about window.open #2873

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Oct 17, 2023

The JSON viewer has been available in Edge for a couple of releases without the need to set a flag. So this PR removes the corresponding part of the docs.
Also, the JSON viewer doesn't work in windows opened with window.open, so adding a note about this.

AB#47103759

@captainbrosset captainbrosset added the cat: webplatform Web Platform-related content. label Oct 17, 2023
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review

@mikehoffms mikehoffms self-requested a review October 18, 2023 15:56
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2e03695:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer-images/enable-flag.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 8c1c552 into main Oct 23, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/json-viewer-note branch October 23, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webplatform Web Platform-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants