Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes for WebView2 120 Prerelease SDK #2870

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Oct 13, 2023

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Oct 13, 2023
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms marked this pull request as ready for review October 14, 2023 00:27
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested. Otherwise looks good

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2e2f84e:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/release-notes.md 💡Suggestion View Details

microsoft-edge/webview2/release-notes.md

  • Line 185, Column 7: [Suggestion: link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2processfailedeventargs.failuresourcemodulepath?view=webview2-dotnet-1.0.2164-prerelease&preserve-view=true' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 194, Column 3: [Suggestion: link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalprocessfailedeventargs?view=webview2-1.0.2164-prerelease&preserve-view=true' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 195, Column 7: [Suggestion: link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalprocessfailedeventargs?view=webview2-1.0.2164-prerelease&preserve-view=true#get_failuresourcemodulepath' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mikehoffms mikehoffms added the on-hold The changes are currently on-hold and awaiting further evaluation. label Oct 18, 2023
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehoffms mikehoffms removed the on-hold The changes are currently on-hold and awaiting further evaluation. label Oct 18, 2023
@Reezaali Reezaali merged commit 749baba into main Oct 18, 2023
1 check passed
@Reezaali Reezaali deleted the user/mikehoffms/relnotes-prerelease-120 branch October 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants