Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus Mode pngs batch 8 (3D View) #2867

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Focus Mode pngs batch 8 (3D View) #2867

merged 9 commits into from
Dec 1, 2023

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Oct 12, 2023 •
edited
Loading

@mikehoffms mikehoffms added cat: devtools DevTools-related content. on-hold The changes are currently on-hold and awaiting further evaluation. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode labels Oct 12, 2023
@captainbrosset captainbrosset changed the base branch from main to user/pabrosse/focus-mode-july-2023 November 29, 2023 10:02
@captainbrosset
Copy link
Contributor

The bug that was blocking this PR got resolved. I merged the big FM branch into this branch and changed the base of this PR to match.

@captainbrosset captainbrosset removed the on-hold The changes are currently on-hold and awaiting further evaluation. label Nov 29, 2023
@captainbrosset captainbrosset marked this pull request as ready for review November 29, 2023 13:37
@captainbrosset captainbrosset self-requested a review November 29, 2023 13:37
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 2ae4ce3:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/3d-view/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/composited-layers-tab.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/composited-layers-tab-galaxy.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/dom-tab.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/more-tools-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/tool-in-activity-bar.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/tool-in-quick-view.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/3d-view/index-images/z-index-tab.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 2fa6aca into user/pabrosse/focus-mode-july-2023 Dec 1, 2023
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/fm-3d-view branch December 1, 2023 08:51
@captainbrosset captainbrosset mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikehoffms @captainbrosset