Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winui2.md to use SetEnvironmentVariable from Environment class for setting default background colour #2863

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

SnowNooDLe
Copy link
Contributor

@SnowNooDLe SnowNooDLe commented Oct 10, 2023

Rendered article section for review:
https://review.learn.microsoft.com/microsoft-edge/webview2/get-started/winui2?branch=pr-en-us-2863#setting-defaultbackgroundcolor
[GitHub's preview]
[Before]

fixes #2862

Updating the document to use the existing method, SetEnvironmentVariable instead of the SetVariable in the section of setting the default background colour.

Edit: It doesn't seem like I can link the issue I just opened. But this is related to #2862

By looking at the Environment class, it doesn't seem like it has the method named SetVariable, and I can see the usage of SetEnvironmentVariable with SmartScreen.

image

AB#46964293

Updating the document to use the existing method, `SetEnvironmentVariable` instead of the `SetVariable` in the section of setting the default background colour.
@learn-build-service-prod
Copy link

Learn Build status updates of commit 58031f5:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/get-started/winui2.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mikehoffms
Copy link
Contributor

@SnowNooDLe - "Edit: It doesn't seem like I can link the issue I just opened. But this is related to [hash]2862" - the Issue says, at bottom, that you linked to it. I was able to link to the Issue two ways:

  • Write "fixes [hash]1234" in topmost comment at PR's main page.
  • PR's main page: Development section - select the Issue. d/k if you have that UI available.

@mikehoffms
Copy link
Contributor

I requested that the PR Admin merge this PR.

@SnowNooDLe
Copy link
Contributor Author

Thanks team :)

@captainbrosset captainbrosset merged commit 81d1228 into MicrosoftDocs:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting DefaultBackgroundColor method for WinUI2&WebView2 seems like needs to be updated
4 participants